Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: update to IDC v19 #124

Merged
merged 4 commits into from
Sep 11, 2024
Merged

ENH: update to IDC v19 #124

merged 4 commits into from
Sep 11, 2024

Conversation

fedorov
Copy link
Member

@fedorov fedorov commented Sep 11, 2024

No description provided.

@fedorov
Copy link
Member Author

fedorov commented Sep 11, 2024

The tests seem to be failing because result_df temporary DF, which is referenced in the query here https://github.com/ImagingDataCommons/idc-index/blob/main/idc_index/index.py#L1563-L1579, is not visible from within the sql_query() function. I don't get it why this test was not failing earlier though...

Could be something introduced in the latest duckdb 1.1.0 that was released just 2 days ago! https://github.com/duckdb/duckdb/releases/tag/v1.1.0

@fedorov fedorov merged commit 44c3977 into main Sep 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant