Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of instance-level download #112

Closed
wants to merge 5 commits into from
Closed

Implementation of instance-level download #112

wants to merge 5 commits into from

Conversation

DanielaSchacherer
Copy link
Contributor

@DanielaSchacherer DanielaSchacherer commented Aug 9, 2024 •
edited
Loading

  • added support of instance-level download as described in Add support for download of single instances instead of whole series #97 (comment)
  • Open problem: we can not estimate / inform the user about download size as we only know the whole series' sizes
  • Open problem: especially the IDCClient.download_from_selection() now contains a lot of if-statements and performs a lot of tasks, which makes the code uneasy to read. But this might also be tackled later.
  • Added printing configurations for codespell hook.

@DanielaSchacherer DanielaSchacherer mentioned this pull request Aug 9, 2024
Open
@fedorov
Copy link
Member

fedorov commented Aug 9, 2024

@DanielaSchacherer before anything, could you make a new branch for this development and use it in place of main? I think you would need to close this PR and make a new one with that branch.

Please see the relevant section of the contributing instructions here: https://github.com/ImagingDataCommons/idc-index/blob/main/CONTRIBUTING.md#how-to-submit-a-pr-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielaSchacherer @fedorov