글쓰기 페이지 카테고리 선택 페이지 퍼블리싱 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
baekteun
reviewed
Jun 30, 2023
Comment on lines
+214
to
+215
| $0.width.equalTo(105) | ||
| $0.height.equalTo(105) |
There was a problem hiding this comment.
Suggested change
| $0.width.equalTo(105) | |
| $0.height.equalTo(105) | |
| $0.size.equalTo(105) |
로 Width랑 Height가 같다면 간단하게 쓸 수 있어요!
Comment on lines
+195
to
+196
| $0.leading.equalTo(feedbackCategoryButton.snp.leading).inset(16) | ||
| $0.top.equalTo(feedbackCategoryButton.snp.top).inset(16) |
There was a problem hiding this comment.
Suggested change
| $0.leading.equalTo(feedbackCategoryButton.snp.leading).inset(16) | |
| $0.top.equalTo(feedbackCategoryButton.snp.top).inset(16) | |
| $0.top.leading.equalTo(feedbackCategoryButton).inset(16) |
로 간추릴 수 있는데 어떤가요?
| } | ||
|
|
||
| private let jobOpeningCategoryTitleStackView = UIStackView().then { | ||
| $0.translatesAutoresizingMaskIntoConstraints = false |
There was a problem hiding this comment.
SnapKit사용하면 makeConstraints 사용할때 자동으로 이거 false로 만들어줍니다
|
conflict 해결 실패로 인해.... 클로즈....되겠습니다... |
|
어이쿠 |
|
Tuist를 쓴다면 놀랍게도 xcodeproj, pbxproj로 인한 conflict가 완전히 없어지죠 |
|
노력하겠습니다...ㅠ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
글쓰기 페이지 (카테고리 선택) 페이지를 퍼블리싱 완료
글쓰기 페이지 (카테고리 선택) 페이지 -> 글쓰기 페이지 (전공 선택) 페이지로 넘어가는 기능이 있습니다