Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code and testing Set Up- Icalialabs::Firebase Gem. #1

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactoring code and testing Set Up- Icalialabs::Firebase Gem. #1

wants to merge 12 commits into from

Conversation

Jorge-Ortiz-Mata
Copy link
Contributor

@Jorge-Ortiz-Mata Jorge-Ortiz-Mata commented Oct 17, 2022 •
edited
Loading

Testing - Icalialabs::Firebase Gem.

This PR contains all the configurations to test this gem.

Main changes.

  • A Couple of readme files were added to show what code users should paste in their applications.
  • It creates a simple firebase_spec.rb using RSpec, Capybara, and Cuprite.
  • Rails gem 7.0.4 was removed to make it compatible with other RoR versions.
  • IF-ELSE statement was changed for SWITCH-CASE, as Rubocop suggests.
  • Methods were added to split each job (generate routes, controller, views, messages).

Extra gems.

Extra Ruby Gems were installed such as:

  • RSpec.
  • Rubocop.
  • Capybara.
  • Cuprite.

@Jorge-Ortiz-Mata Jorge-Ortiz-Mata changed the title Testing - Icalialabs::Firebase Gem. Testing Set Up- Icalialabs::Firebase Gem. Oct 20, 2022
@Jorge-Ortiz-Mata Jorge-Ortiz-Mata changed the title Testing Set Up- Icalialabs::Firebase Gem. Refactoring code and testing Set Up- Icalialabs::Firebase Gem. Oct 20, 2022
JuanPabloGil
JuanPabloGil approved these changes Oct 26, 2022
View reviewed changes
Copy link

@JuanPabloGil JuanPabloGil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanPabloGil JuanPabloGil JuanPabloGil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorge-Ortiz-Mata @JuanPabloGil