Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "Bounce in" to "Bounce out" and viceversa on master branch, they were inverted. #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TefiC
Copy link

@TefiC TefiC commented Aug 16, 2016

Hi! I love your library, I've used it for my projects and I wanted to contribute since I noticed that on the demo site http://ianlunn.github.io/Hover/ and on the source files, "Bounce in" and "Bounce out" effects are inverted. "Bounce in" bounces out and "Bound out" bounces in. I made these changes to the source file and to the minified file as well, on the master branch and made a pull request for the gh-pages branch with the same changes.

Swapped their names because they were inverted, "Bounce in" bounced out and viceversa, I changed them to make the animation correspond to the class name.
Swapped their names because they were inverted, "Bounce in" bounced out and viceversa, I changed them to make the animation correspond to the class name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant