Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null lookat #19

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix null lookat #19

merged 3 commits into from
Sep 11, 2024

Commits on Aug 19, 2024

  1. Added a unit test that demonstrates the failure of a camera.LookAt pr… 

    …operty

to be null in this manifest; and that it throws an exception
    @vincentmarchetti
    vincentmarchetti committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    131acd0 View commit details
    Browse the repository at this point in the history

  2. Changed code that the new unit-test, and all other 3d unit-tests, pass.

    @vincentmarchetti
    vincentmarchetti committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7c29217 View commit details
    Browse the repository at this point in the history

  3. rewrote the Camera.LookAt get accessor to ensure that 

    when the Camera as a body resource does not define a value for a LookAt property,
then the value returned is null
    @vincentmarchetti
    vincentmarchetti committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3c61b2d View commit details
    Browse the repository at this point in the history