Execom and alumini data #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The changes look good, but there are lot of unused variables and SocietyExecom Component is unnessarily worked on which was supposed to be done by @sannidhi-s-shetty, update the merging branch to capExecom
| @@ -0,0 +1,63 @@ | |||
| import React, { useState, useEffect } from 'react'; | |||
There was a problem hiding this comment.
This file acts as a component, better to move to Components folder
|
|
||
| const [member, setMember] = useState([]); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
This functionality is being developed by @sannidhi-s-shetty, please coordinte with her.
| <AlumniAccordions members={alumni.compsoc} color="rgb(80 161 99)" /> | ||
| </Paper> */} | ||
| <SocietyExec sid = {ecats.compsoc}/> | ||
| <AlumniAccordions members={alumni.compsoc} sid = {ecats.compsoc} color="rgb(80 161 99)" /> |
There was a problem hiding this comment.
why are we still passing the members as a prop, remove it
Suggested change
| <AlumniAccordions members={alumni.compsoc} sid = {ecats.compsoc} color="rgb(80 161 99)" /> | |
| <AlumniAccordions sid = {ecats.compsoc} color="rgb(80 161 99)" /> |
| @@ -0,0 +1,153 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
This file is unnessary, please delete it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier Execom and Alumni data is stored in local storage. This data is redirected to api. Changes are done in front-end code to pull the data from api.