Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implememted react-query for events page #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Prajwalprakash3722
Copy link
Member

@Prajwalprakash3722 Prajwalprakash3722 commented Mar 27, 2023

  • Added a useQuery hook to fetch the events data from the server using axios.
  • Implemented a loading indicator using Material UI Skeletons while the data is being fetched.
  • Reorganized the code to make it more readable and maintainable.
  • Tested the implementation thoroughly to ensure that it works as expected.

I believe this updated code is a more efficient and maintainable solution compared to the previous useEffect() implementation. Please review and merge the changes if they meet your requirements. You can find more details about the changes and the reference link to the original issue in the PR.

Reference : #99

Requesting a review from the OG author(s) of the code as they are the ones who wrote it.

Please Note: This implementation is more like a prototype

Copy link
Member

@chrisvrose chrisvrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would approve but since it is a POC I am not putting it for merge yet and I am not aware of further discussions.

src/pages/EventsPage.js Outdated Show resolved Hide resolved
@Prajwalprakash3722
Copy link
Member Author

Yes, I agree with you @chrisvrose, this is still a POC, however we can improve many things, perhaps @dragonfist453, @MayurSChittaragi can initiate the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants