Merger trees artefact treatment: mass swapping and massive transients

[angel-chandro]

1. Redundancy in define_central_subhalo for mass swapping fix
   Subhalo properties only redefined with the host halo properties for central subhalos when applying mass swapping fixes. Halos vvir and concentration defined with host halo properties and after ensuring their mass growth

2. Massive transients implementations
   Input file with a list of the main branch subhalos that are classified as transients and the halos that host them. When building the trees and making connections subhalo-descendant, if there is a transient in the descendant halo and several constraints are fulfilled, then default subhalo-descendant connection is broken and a subhalo-transient connection has priority. These criteria can be summarized as: 1. transient more massive than descendant, 2. subhalo-descendant connection has a severe mass loss, 3. subhalo-transient connection is smooth enough in terms of the mass. Define parameters used for the massive transients treatment and for computing statistics. Set to true the default flags to apply mass swapping and massive transient fixes.
   After playing with the parameters involved in the transient fixes, we set their default values considering mass changes more or less smooth: the mass ratio to break a main progenitor-subhalo link should be <0.7 while the mass ratio to create a new main progenitor-transient link should be in the range 0.1-3.

Summary by Sourcery

This pull request introduces fixes for mass swapping in central subhalos and implements a new treatment for massive transients. It includes new parameters for controlling these fixes and enhances the tree building process to prioritize subhalo-transient connections under certain conditions. Additionally, it updates the execution configuration and logging to support these new features.

• New Features:
  • Implemented mass swapping fixes for central subhalos, ensuring their properties are redefined with host halo properties.
  • Introduced massive transient treatment, allowing subhalo-transient connections based on specific criteria to improve tree building and connection accuracy.
• Enhancements:
  • Added parameters for massive transient treatment, including flags and mass ratio thresholds, to the execution configuration.
  • Updated the tree building process to include statistics for massive transient events, providing detailed logging of the fixes applied.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces fixes for mass swapping and implements massive transient treatments. The changes include updating the tree building logic to handle massive transient events, adding configuration parameters for these treatments, and modifying the Subhalo and Halo classes to include transient-related attributes.

File-Level Changes

Files	Changes
src/tree_builder.cpp include/tree_builder.h	Updated tree building logic to handle massive transient events and apply mass swapping fixes.
src/merger_tree_reader.cpp include/halo.h	Added logic to read and set transient flags for halos.
include/execution.h src/execution.cpp sample_lagos23.cfg	Added and loaded configuration parameters for massive transients treatment.
include/subhalo.h include/halo.h	Added transient-related attributes to Subhalo and Halo classes.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @angel-chandro - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}