Fix char signedness issue in _crc32c_sw_slicing_by_8() #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `_crc32c_sw_slicing_by_8()` to use `unsigned char` for `p_buf`,
to fix incorrect results on platforms with signed `char` such as SPARC.
The code has been casting `unsigned char *` to `char *` for no apparent
reason, and this broke the bitshifts in the big endian blocks.
Particularly,
crc ^= *(p_buf++) << 16
would be XOR-ed against `0xffee0000` rather than `0x00ee0000`.
Fixes ICRAR#43
|
Thanks @mgorny, not only for the PR, but also for reporting the issue and doing the root-cause analysis. Changes look fine to me, I agree the cast was completely unnecessary. I'll tag a release shortly. |
|
@mgorny 2.4.1 has been tagged, a new release will hopefully appear automatically in PyPI in an hour or less; otherwise tomorrow I'll have a look. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
_crc32c_sw_slicing_by_8()to useunsigned charforp_buf, to fix incorrect results on platforms with signedcharsuch as SPARC. The code has been castingunsigned char *tochar *for no apparent reason, and this broke the bitshifts in the big endian blocks.Particularly,
would be XOR-ed against
0xffee0000rather than0x00ee0000.Fixes #43