Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danhooke inconsistencies #26

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

danhooke
Copy link
Contributor

@danhooke danhooke commented Sep 7, 2023

Updated the R10 regions to be consistent with the IPCC AR6 WGII Annex II R10 regions (https://www.ipcc.ch/report/ar6/wg3/downloads/report/IPCC_AR6_WGIII_Annex-II.pdf).
There are some small nations which were already in the common-definitions R20 regions but were not included in any of the IPCC R10 regions (e.g. Taiwan, Hong Kong), which I left in.

Also updated spelling of Czechia at R10 level.
Added Albania to Europe R10 (already in R5 and R9 levels)

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please make sure that the yaml files have a maximum line-length of 88 characters.

Two specific inline suggestions, then good to be merged.

definitions/region/common.yaml Outdated Show resolved Hide resolved
definitions/region/common.yaml Show resolved Hide resolved
@danhooke
Copy link
Contributor Author

danhooke commented Sep 8, 2023

Thanks, amended

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danielhuppmann danielhuppmann merged commit 87f3917 into IAMconsortium:main Sep 11, 2023
2 checks passed
@danhooke danhooke deleted the danhooke-inconsistencies branch September 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants