Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the Drivetrain's getRotation method may return angles > 360° #39

Open
gcschmit opened this issue Jun 3, 2023 · 0 comments
Open

the Drivetrain's getRotation method may return angles > 360° #39

gcschmit opened this issue Jun 3, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@gcschmit
Copy link
Contributor

gcschmit commented Jun 3, 2023

The Rotation2d class doesn't constrain the range of angles. The Drivetrain class' getRotation method may return angles greater than 360°. We need to carefully consider what the intended behavior should be.
@gcschmit gcschmit added the help wanted Extra attention is needed label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gcschmit