Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-888: Stale feature flag #6437

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Sep 24, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Stale a feature flag that is only use on enterprise

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

COPY FROM #6099 SInce I can not rerun e2e LSE

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 6ed1820
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66f5f18fbadde5000937eee1

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 6ed1820
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66f5f18f020b7c000824646c

@luarmr
Copy link
Contributor Author

luarmr commented Sep 26, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/stores/types.d.ts

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.64%. Comparing base (b1576ee) to head (6ed1820).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6437      +/-   ##
===========================================
- Coverage    76.65%   76.64%   -0.01%     
===========================================
  Files          169      169              
  Lines        13749    13749              
===========================================
- Hits         10539    10538       -1     
- Misses        3210     3211       +1     
Flag Coverage Δ
pytests 76.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr merged commit a99f440 into develop Sep 27, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants