-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort regions by area for rectangles, polygons and ellipses #6211
base: develop
Are you sure you want to change the base?
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
4bcc8ff
to
db87a33
Compare
(removed changes to web/dist) |
Hi, thank you for the PR! I have a question: |
Thanks for your feedback @makseq « By Surface » will appear, regardless of the types of the regions. « By Type » seems misleading to me as regions with a defined surface (e.g. rectangle and ellipses) are sorted regardless of their type but according to their surface. It is illustrated in the screenshot of the initial comment of this PR. |
@LouisJULIEN Ah, I misunderstood the |
db87a33
to
24bf39d
Compare
24bf39d
to
5b60f53
Compare
@makseq fair point, I renamed surface to area |
Hey @makseq, could you give me an update on the last changes? |
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
Having surface sorted only by score or date wasn't relevant to me. I wanted to have regions sorted by surface. It maximizes my chances to click on smaller surfaces. Without surface sorting, bigger surfaces tends to be on top of smaller surfaces, making it harder to reach small surface by click
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
In addition to date and score, regions can now be sorted by surface if they are among Rectangle, Polygon or Ellipse.
What is the current behavior?
(if this is a breaking or feature change)
No way to sort regions by surface
What libraries were added/updated?
None
Does this change affect performance?
(if so describe the impacts positive or negative)
It could affect performance when sorting lots of regions by surface. I didn't observe it. It affects performance only when the feature is directly used.
Does this change affect security?
No
What alternative approaches were there?
Click on the region window and hope to find the good one quick
What feature flags were used to cover this change?
None
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Regions Sorting
Others