Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOGGER as argument to hotswap-agent.jar #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add LOGGER as argument to hotswap-agent.jar #332

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2020

Hi,

First thanks a lot for your project, it is saving me lots of time.

I needed to set LOGGER=warning and have zero logging.

This patch makes it work by passing to JavaAgent like this:

-javaagent:c:\dev\HotswapAgent.jar=LOGGER=warning

Kind regards,

Bobbie

This helps decrease verbosity in logs.
@skybber
Copy link
Contributor

skybber commented Jan 24, 2020

Is it necessary to change default level in hotswap-agent.properties as it is in you patch?

@ghost
Copy link
Author

ghost commented Jan 24, 2020

Yes, otherwise it goes back to INFO no matter what I set it to.

Note that is INFO by default in AgentLogger.java.

@skybber
Copy link
Contributor

skybber commented Jan 29, 2020

I think that there should be much more general concept of overriding HA properties from commandline using -D parameter, it is missing now in HA. It looks, it could be easily done modifying HotswapProperties.java .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant