Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpich: fix build #150225

Closed
wants to merge 1 commit into from
Closed

mpich: fix build #150225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Formula/m/mpich.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,16 @@

args = %W[
--disable-dependency-tracking
--disable-silent-rules
--enable-fast=all,O3
--enable-g=dbg
--enable-romio
--enable-shared
--with-hwloc=#{Formula["hwloc"].opt_prefix}
--with-pm=hydra
F77=gfortran
FC=gfortran
FCFLAGS=-fallow-argument-mismatch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: is this, and the FFLAGS=-fallow-argument-mismatch below that says "Flag for compatibility with GCC 10" still necessary? Sounds temporary with how the comment is written

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try removing it. I don't think it is no longer required (at least to be passed explicitly). Worst case, configure/make would fail and we would notice.

--disable-silent-rules
--prefix=#{prefix}
--mandir=#{man}
]
Expand All @@ -84,7 +85,7 @@
system "make", "install"
end

test do

Check warning on line 88 in Formula/m/mpich.rb

View workflow job for this annotation

GitHub Actions / macOS 14-arm64

`brew test --verbose mpich` failed on macOS Sonoma (14) on Apple Silicon! 

/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/bin/bundle clean
==> Testing mpich
==> /opt/homebrew/Cellar/mpich/4.1.2/bin/mpicc hello.c -o hello
ld: unknown options: -commons 
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: mpich: failed
An exception occurred within a child process:
  BuildError: Failed executing: /opt/homebrew/Cellar/mpich/4.1.2/bin/mpicc hello.c -o hello
/opt/homebrew/Library/Homebrew/formula.rb:2735:in `block in system'
/opt/homebrew/Library/Homebrew/formula.rb:2671:in `open'
/opt/homebrew/Library/Homebrew/formula.rb:2671:in `system'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
/opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/m/mpich.rb:101:in `block in <class:Mpich>'
/opt/homebrew/Library/Homebrew/formula.rb:2494:in `block (3 levels) in run_test'
/opt/homebrew/Library/Homebrew/extend/kernel.rb:499:in `with_env'
/opt/homebrew/Library/Homebrew/formula.rb:2493:in `block (2 levels) in run_test'
/opt/homebrew/Library/Homebrew/formula.rb:1052:in `with_logging'
/opt/homebrew/Library/Homebrew/formula.rb:2492:in `block in run_test'
/opt/homebrew/Library/Homebrew/mktemp.rb:75:in `block in run'
/opt/homebrew/Library/Homebrew/mktemp.rb:75:in `chdir'
/opt/homebrew/Library/Homebrew/mktemp.rb:75:in `run'
/opt/homebrew/Library/Homebrew/formula.rb:2786:in `mktemp'
/opt/homebrew/Library/Homebrew/formula.rb:2486:in `run_test'
/opt/homebrew/Library/Homebrew/test.rb:44:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
/opt/homebrew/Library/Homebrew/test.rb:48:in `<main>'
(testpath/"hello.c").write <<~EOS
#include <mpi.h>
#include <stdio.h>
Expand Down
Loading