Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowball 2.2.0 (new formula) #111779

Closed
wants to merge 1 commit into from
Closed

snowball 2.2.0 (new formula) #111779

wants to merge 1 commit into from

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Sep 27, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Stemming algorithms

Notes

  • there is no make install target
  • it may make sense to alias as / rename to libstemmer (Ubuntu package)

@BrewTestBot BrewTestBot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 27, 2022
def install
system "make"

lib.install "libstemmer.a"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems much nicer to ship a shared library. Can we ask upstream if that's something they'd support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an open issue and PR for it (for Linux, but can update for Mac if accepted).

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@ankane
Copy link
Contributor Author

ankane commented Sep 28, 2022

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants