Fix the name of Taiwan #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the consistency between this project and the pycountry ISO databases, revert to Taiwan's name to "Taiwan, Province of China". Refer to [1] for more details. [1] https://github.com/pycountry/pycountry/blob/main/src/pycountry/databases/iso3166-1.json Signed-off-by: Dongliang Mu <[email protected]>
|
Hi, thank you for this PR. Could you please also check what other countries are not inline with ISO representation? |
|
Sure. I will continue to double check the name of other countries. |
|
Please take a look at the following gist: https://gist.github.com/mudongliang/e0de9053115e705017b38695389ecf69 |
|
@yigitguler finished checking all warnings. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the consistency between this project and the pycountry ISO databases, revert to Taiwan's name to "Taiwan, Province of China".
Refer to [1] for more details.
[1] https://github.com/pycountry/pycountry/blob/main/src/pycountry/databases/iso3166-1.json