Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test_filter.py #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create test_filter.py #510

wants to merge 1 commit into from

Conversation

zoharasulin
Copy link

HI .
This PR was sent as part of course OSDC taught by: @szabgab.
I add file test to your code filter.py.
I think this tests can help your project when in further- you change the code or maybe add more features.
I see your project and project API that base on your code and it very intersting.
I wonder that was in your list json universities and colleges from Israel(my country :))
Nice job!

@szabgab
Copy link

szabgab commented Jun 13, 2023

I like these tests very much!

@yigitguler
Copy link
Member

Hello! Thank you very much for this contribution.
However, I suspect it is opened to the wrong repository.
This is the repository of the JSON file. The API is located here: https://github.com/Hipo/university-domains-list-api/
Also the build fails to work. I assume this is related with the repository difference.

@zoharasulin
Copy link
Author

Hello @yigitguler
First of all I'm sorry it fell.
I did tests and saw that everything was running.
Probably something small in the import.
Regarding what you say, it has nothing to do with your script, I simply saw a filter.py in repo, according to what I understand, sorts the universities and etc.
This is not true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants