Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-language support #153

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Added multi-language support #153

wants to merge 3 commits into from

Conversation

troskop
Copy link

@troskop troskop commented Sep 28, 2015

Hello,
I really enjoy the "hextris"-game.

But it is to bad that it only worked in english. So i coded something to allow this game to support more then one language. As an example I also added support for the german language (de-DE).

Hope this helps you app. If you have questions etc. feel free to ask!

@lengstrom
Copy link
Member

Hey @troskop - this looks really good! I'll try to merge this in later - however, we'll have to thoroughly test it. Have you tested it much yet?

@troskop
Copy link
Author

troskop commented Oct 7, 2015

I tested it using different browsers (Chromium, Firefox; both running on ubuntu 15.04).
But testing is always good!

PS: This script has one small by-effect. The user has to download some files more (the language-files and the "LanguageServer.js").

I hope it will work.

@lengstrom
Copy link
Member

@garrettdreyfus and I will start testing it as well! That's fine, language files are probably pretty small, right?

@troskop
Copy link
Author

troskop commented Oct 7, 2015

The german file is for example just 3.48 KB large. This is nothing today. Every ad on webpages is larger :D

@lengstrom
Copy link
Member

Yep that's no big deal! 👍

On Wed, Oct 7, 2015 at 1:53 AM, Thomas Roskop [email protected]
wrote:

The german file is for example just 3.48 KB large. This is nothing today.
Every ad on webpages is larger :D


Reply to this email directly or view it on GitHub
#153 (comment).

@troskop
Copy link
Author

troskop commented Oct 7, 2015

Could you please inform me when you've decided about this request?

@troskop troskop closed this Oct 7, 2015
@troskop troskop reopened this Oct 7, 2015
@lengstrom
Copy link
Member

I would like to merge in this pull request but I have to review it to make
sure that it doesn't break anything. I'm an undergraduate as well, so I'm
pretty busy - it'll probably be a few weeks before this gets merged in,
sorry. @garrettdreyfus are you interested in looking into this at all?

On Wed, Oct 7, 2015 at 2:10 PM, Thomas Roskop [email protected]
wrote:

Could you please inform me when you've decided about this request?


Reply to this email directly or view it on GitHub
#153 (comment).

@troskop
Copy link
Author

troskop commented Oct 27, 2015

And, have you decided yet?

@lengstrom
Copy link
Member

@troskop I have midterms right now at my university - sorry for the delay. I think @garrettdreyfus has started looking at integration though - we should be ready soon (within the next month).

@troskop
Copy link
Author

troskop commented Mar 31, 2016

Hi!
Have you found the time to integrate the multi-language-support to hextris?

@ghost
Copy link

ghost commented Aug 1, 2016

Hello,
Thanks for this great work!
I would be also interested to see this app translatable and I can help in the French translation.

@Poussinou
Copy link

I can also translate the app in french, multi language support is important for us ^^

@themichaelyang
Copy link
Member

themichaelyang commented Feb 15, 2018

Hi @troskop! I'd be happy to take a look at this request.

Unfortunately, I think something went wrong with this PR because you deleted the fork. Would you be able to submit another PR with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants