Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework EffectCombiner into ECS #291

Merged
merged 21 commits into from
Feb 1, 2024
Merged

Rework EffectCombiner into ECS #291

merged 21 commits into from
Feb 1, 2024

Conversation

Helco
Copy link
Owner

@Helco Helco commented Jan 28, 2024

After going back and forth about whether EffectCombiner and their parts should be integrated into ECS (and therefore better use batching) I have decided to quickly try it out and choose later.

Also this turned into another rework of dynamic meshes, as for batch-rendering effect parts I needed partially-resettable vertex buffers and custom index buffers. However this should also allow us to again use a single instance buffer across all ModelRenderer

Result so far: Although there might be edge cases hiding in probably something like ElectricBolt or ParticleEmitter and I am not sure that I implemented the sparks renderer correctly I will merge this as is and setup a group issue to track the remaining combiner parts to implement.
(Also beam effects and game-controlled progress)
With MovingPlanes and RandomPlanes implemented (fully) this accounts for 43% of combiner parts.

@Helco Helco marked this pull request as ready for review February 1, 2024 20:22
@Helco Helco merged commit a8877d9 into master Feb 1, 2024
2 checks passed
@Helco Helco deleted the ecs-effect-combiner branch February 1, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant