UI: deck: order lists correctly #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helco
requested changes
Jan 26, 2024
zzre/game/systems/ui/ScrDeck.cs
Outdated
| Tab.AttackSpells => deck.Inventory.AttackSpells, | ||
| Tab.SupportSpells => deck.Inventory.SupportSpells, | ||
| Tab.Items => deck.Inventory.Items.OrderBy(c => c.cardId.EntityId), | ||
| Tab.Fairies => deck.Inventory.Fairies.OrderBy(c => -c.level), |
There was a problem hiding this comment.
nitpick: OrderByDescending would be slightly more clear
There was a problem hiding this comment.
Glad to know more api, fixed
zzre/game/systems/ui/ScrDeck.cs
Outdated
| Tab.Fairies => deck.Inventory.Fairies, | ||
| Tab.AttackSpells => deck.Inventory.AttackSpells, | ||
| Tab.SupportSpells => deck.Inventory.SupportSpells, | ||
| Tab.Items => deck.Inventory.Items.OrderBy(c => c.cardId.EntityId), |
There was a problem hiding this comment.
There the sorting is unfortunately not quite correct, but Zanzarah is a bit weird with this:
There is a column in the ItemRow, currently still called Unknown (should probably be Type) that is used as first sorting term with the order 1 -> 0 -> everything else
The EntityId is used as a secondary sorting term
There was a problem hiding this comment.
fixed
that's so obscure lol, love it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.