Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix deployment 2 #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobil4sk
Copy link
Member

Unlike #178, this doesn't change the way the site is deployed, which caused some DNS issue when migrating nekovm.org. This should get the site deploying again while we figure out how to solve that.

@kLabz
Copy link
Contributor

kLabz commented Aug 31, 2024

There's no problem anymore with how nekovm is deployed though?
I don't think #178 is wrong, and looks less weird than this git user thing 🤔

@tobil4sk
Copy link
Member Author

There's no problem anymore with how nekovm is deployed though?
I don't think #178 is wrong, and looks less weird than this git user thing 🤔

Yeah #178 is the correct solution, but if it is still blocked due to the DNS issues, then this version uses the same gh-pages branch workflow as travis so it should be safe to merge without breaking anything. This could be merged to get deployment working immediately in the meantime, then we can move to the setup in #178 once we are more confident about that.

The git user setup allows pushing/committing from the github-actions[bot] user, which has permission to push from the automated token and doesn't require a PAT being set up as it was previously for the @haxe-ci bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants