Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for cartesian grid #612

Merged
merged 11 commits into from
Aug 25, 2023

Conversation

Somya-Bansal159
Copy link
Collaborator

Update tests for the cartesian grid. Created a draft request, after which I will finalise the changes.

@Somya-Bansal159 Somya-Bansal159 marked this pull request as ready for review August 18, 2023 20:04
@Somya-Bansal159 Somya-Bansal159 changed the title WIP : fix tests for cartesian grid Fix tests for cartesian grid Aug 18, 2023
@EdwardMoyse
Copy link
Collaborator

Hi @Somya-Bansal159 - this is weird ... I can't quite work out why the CI is failing. Maybe the test needs to be documented?

Can you try the instructions here:
https://github.com/HSF/phoenix/blob/main/guides/developers/test-setup.md#failures-in-documentation-coverage
?

@EdwardMoyse
Copy link
Collaborator

Trying to trigger the CI

@EdwardMoyse EdwardMoyse merged commit 63bb5ed into HSF:main Aug 25, 2023
1 check passed
@Somya-Bansal159 Somya-Bansal159 deleted the cartesian-grid-lint-fix branch August 26, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants