Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kgoergen patch 1 #9

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Kgoergen patch 1 #9

merged 9 commits into from
Aug 23, 2024

Conversation

kgoergen
Copy link
Collaborator

Merge of TSMP1 workflow engine with CRC DETECT TSMP1 scripts in use. More logging. More informative run monitoring. Adjustments due to changed dependencies after JSC slurm update on 2024-08-06. All edits are tested.

kgoergen and others added 3 commits August 18, 2024 10:26
During usage in the CRC DETECT project some refinements were done to
the workflow engine (WFE), there are merged back now to the WFE
template.

After 2024-08-06 slurm upgrade some dependency job chain related
syntax changees led to to an update of the starter.sh script.

Run monitoring, debugging, and reproducibility were improved: the
slurm Job-name now contains the Job-ID and the startdate, the slurm
log files are stored with simres, the mapping files as well.

Changes:
ctrl/SimInfo.sh
ctrl/aux_LinkFromScratch.sh
ctrl/aux_LinkToScratch.sh
ctrl/aux_MigrateFromScratch.sh
ctrl/aux_UnTarManyTars.sh
ctrl/aux_checkCompleteness.sh
ctrl/aux_gunzip.sh
ctrl/aux_gzip.sh
ctrl/aux_restageTape.sh
ctrl/aux_sha512sum.sh
ctrl/envs/PythonHeAT_Stage2022_20221024_cbce1b93.ini
ctrl/export_paths.ksh -> ctrl/export_paths.sh
ctrl/get_NumLeapDays.sh
ctrl/start_helper.sh
ctrl/start_prepro.sh
ctrl/start_simulation.sh
ctrl/starter.sh
ctrl/submit_finishing.sh
ctrl/submit_postpro.sh
ctrl/submit_prepro.sh
ctrl/submit_simulation.sh
Main branch is protected, need to go via PR of patch branch.
@kgoergen kgoergen added bug Something isn't working enhancement New feature or request labels Aug 19, 2024
@kgoergen kgoergen requested a review from s-poll August 19, 2024 10:09
@kgoergen
Copy link
Collaborator Author

kgoergen commented Aug 19, 2024

There is a bug in the starter.sh; was forgotten in the merge; timing is not set

export TSTP_COSMO=${TSTP_COSMO}
export TSTP_CLM=${TSTP_CLM}
export TSTP_PARFLOW=${TSTP_PARFLOW}

Forgot to put the timstep information in starter.sh which is needed
for the start_simulation.sh to work properly.
@kgoergen
Copy link
Collaborator Author

missing time information has been added

@kgoergen
Copy link
Collaborator Author

Real usage revealed some more issues.

@s-poll s-poll merged commit 147e18d into main Aug 23, 2024
1 check failed
@kgoergen kgoergen deleted the kgoergen-patch-1 branch August 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants