Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev.md to 3.5.5.236 #82

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Update dev.md to 3.5.5.236 #82

merged 5 commits into from
Feb 23, 2024

Conversation

burningtnt
Copy link
Member

@burningtnt burningtnt commented Feb 19, 2024

  • GP: Github PR ID
  • GC: Git Commit Hash

@hejiehao
Copy link
Contributor

为啥不是直接 # + 编号?

@burningtnt
Copy link
Member Author

用两位英文字母可以表达类别(即 PR / Issue / Commit)

@hejiehao
Copy link
Contributor

用两位英文字母可以表达类别(即 PR / Issue / Commit)

我认为使用 # 更加通俗易懂

@burningtnt
Copy link
Member Author

burningtnt commented Feb 21, 2024

我认为使用 # 更加通俗易懂

未来如果有新的平台,或贡献方式,# 就不准确了

目前使用的是 GP-XXXXGC-XXXX 的方式

@burningtnt
Copy link
Member Author

如果没有什么大问题,我能否先合并本 PR?快照版已经发出很久了

@hejiehao
Copy link
Contributor

但是你似乎没有在文档说明 GP 和 GC 的意思

@burningtnt
Copy link
Member Author

但是你似乎没有在文档说明 GP 和 GC 的意思

这个我不准备说明。看得懂的人不需要说明也看得懂,看不懂的人说明了也看不懂。

我的 IDEA 是提供一个静态页面,填入 GP-XXXXGC-XXXX 后,在前端解析数据并跳转,这样可以给小白玩家看到详细信息的方法

@zkitefly
Copy link
Member

问一下,这些 Change 是看 https://ci.huangyuhui.net/view/all/job/HMCL/236/changes 的吗

我的建议是看 CI 上的 Change,GitHub 上的目前是手动打的标签,会有些不准

_changelog/dev.md Outdated Show resolved Hide resolved
@burningtnt
Copy link
Member Author

,会有些不准

当时看的是 GitHub Release

刚刚确认了一下,commit hash 是对的。虽说过程有问题,但结果没问题(

@zkitefly
Copy link
Member

,会有些不准

当时看的是 GitHub Release

刚刚确认了一下,commit hash 是对的。虽说过程有问题,但结果没问题(

文档上的都在 CI 的 Change 是吗,是就可以了

@burningtnt
Copy link
Member Author

burningtnt commented Feb 23, 2024

已更改。没啥问题我就 Merge 了
修复选中使用非默认皮肤的离线账户时,启动器主页头像会被错误地显示为默认皮肤头像的问题,现在正常显示用户选择的皮肤头像

@burningtnt burningtnt merged commit 7e91a91 into main Feb 23, 2024
1 check passed
@burningtnt burningtnt deleted the changelog/3.5.5.236 branch February 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants