Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use JWT_PUBLIC_KEY from environment rather than file #2865

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

johndeange
Copy link
Contributor

@johndeange johndeange commented Sep 30, 2024

What changed

The higher environments in Azure will use a different Public/Private Key pair.

This PR prepares for the functionality to allow different keys by deleting the Public Crypto Key in the repo and using environment variable instead.

Issue

#2811

How to test

Automated tests pass.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

If relevant, e.g. for a link to a piece of markdown documentation

@johndeange johndeange merged commit 4b57512 into main Sep 30, 2024
40 checks passed
@johndeange johndeange deleted the use-public-key-env branch September 30, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants