-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement test for H5Dget_storage_size #61
Conversation
2f5f9ea
to
d5d0e01
Compare
vol_dataset_test.c
Outdated
PART_ERROR(H5Dget_storage_size_contiguous); | ||
} | ||
|
||
if (H5Dget_storage_size(dset_id_contiguous) <= 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only check == 0 for these calls. Since the return value is an hsize_t, this will probably generate compiler warnings about comparing an unsigned to a negative value
537627a
to
b2bc962
Compare
vol_dataset_test.c
Outdated
PART_ERROR(H5Dget_storage_size_chunked); | ||
} | ||
|
||
if (H5Dget_storage_size(dset_id_chunked) <= 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for just 0 here as well
vol_dataset_test.c
Outdated
PART_ERROR(H5Dget_storage_size_filtered); | ||
} | ||
|
||
if (H5Dget_storage_size(dset_id_filtered) <= 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for just 0 here as well
da0a68b
to
57272c6
Compare
Different VOL connectors could allocate different amounts of storage for the same data, so these tests just check that get_storage_size doesn't fail and reports a nonzero quantity.