Implement test for H5Dget_storage_size #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
get_storage_size_test
branch
from
2f5f9ea
to
d5d0e01
Compare
vol_dataset_test.c
Outdated
| PART_ERROR(H5Dget_storage_size_contiguous); | ||
| } | ||
|
|
||
| if (H5Dget_storage_size(dset_id_contiguous) <= 0) { |
There was a problem hiding this comment.
Should only check == 0 for these calls. Since the return value is an hsize_t, this will probably generate compiler warnings about comparing an unsigned to a negative value
mattjala
force-pushed
the
get_storage_size_test
branch
from
537627a
to
b2bc962
Compare
vol_dataset_test.c
Outdated
| PART_ERROR(H5Dget_storage_size_chunked); | ||
| } | ||
|
|
||
| if (H5Dget_storage_size(dset_id_chunked) <= 0) { |
There was a problem hiding this comment.
Check for just 0 here as well
vol_dataset_test.c
Outdated
| PART_ERROR(H5Dget_storage_size_filtered); | ||
| } | ||
|
|
||
| if (H5Dget_storage_size(dset_id_filtered) <= 0) { |
There was a problem hiding this comment.
Check for just 0 here as well
mattjala
force-pushed
the
get_storage_size_test
branch
from
da0a68b
to
57272c6
Compare
jhendersonHDF
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different VOL connectors could allocate different amounts of storage for the same data, so these tests just check that get_storage_size doesn't fail and reports a nonzero quantity.