-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to use gcc-14 #4983
base: develop
Are you sure you want to change the base?
Update CI to use gcc-14 #4983
Conversation
Adds two new warnings for gcc 13: -Wxor-used-as-pow -Wenum-int-mismatch And sets up Autotools and CMake to use them. The Autotools now also pull in the gcc 12 developer warnings. Also bumps the CI to use gcc 13 instead of 12.
This is unnecessary as all the warnings are already set with -Wall
I'll probably do the warnings in separate PRs before this will be ready to merge |
hl/src/H5TB.c
Outdated
@@ -3185,7 +3185,7 @@ H5TB_create_type(hid_t loc_id, const char *dset_name, size_t type_size, const si | |||
if (H5TBget_table_info(loc_id, dset_name, &nfields, NULL) < 0) | |||
goto out; | |||
|
|||
if (NULL == (fnames = (char **)calloc(sizeof(char *), (size_t)nfields))) | |||
if (NULL == (fnames = (char **)calloc((size_t)nfields), sizeof(char *))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (NULL == (fnames = (char **)calloc((size_t)nfields), sizeof(char *))) | |
if (NULL == (fnames = (char **)calloc((size_t)nfields, sizeof(char *)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misplaced ')' causes build error.
…o gcc_13_support
@@ -28,7 +28,7 @@ permissions: | |||
|
|||
jobs: | |||
check: | |||
runs-on: ubuntu-latest | |||
runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not specify latest and always use a specific version on all CI?
No description provided.