Update CI to use gcc-14 #4983
Draft
Update CI to use gcc-14 #4983
+330
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new warnings for gcc 13:
-Wxor-used-as-pow
-Wenum-int-mismatch
And sets up Autotools and CMake to use them.
The Autotools now also pull in the gcc 12 developer warnings.
Also bumps the CI to use gcc 13 instead of 12.
This is unnecessary as all the warnings are already set with -Wall
derobins
added
Priority - 2. Medium ⏹
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
|
I'll probably do the warnings in separate PRs before this will be ready to merge |
bmribler
approved these changes
Oct 19, 2024
qkoziol
approved these changes
Oct 19, 2024
bmribler
approved these changes
Oct 19, 2024
lrknox
reviewed
Oct 20, 2024
hl/src/H5TB.c
Outdated
| @@ -3185,7 +3185,7 @@ H5TB_create_type(hid_t loc_id, const char *dset_name, size_t type_size, const si | |||
| if (H5TBget_table_info(loc_id, dset_name, &nfields, NULL) < 0) | |||
| goto out; | |||
|
|
|||
| if (NULL == (fnames = (char **)calloc(sizeof(char *), (size_t)nfields))) | |||
| if (NULL == (fnames = (char **)calloc((size_t)nfields), sizeof(char *))) | |||
There was a problem hiding this comment.
Suggested change
| if (NULL == (fnames = (char **)calloc((size_t)nfields), sizeof(char *))) | |
| if (NULL == (fnames = (char **)calloc((size_t)nfields, sizeof(char *)))) |
There was a problem hiding this comment.
Misplaced ')' causes build error.
lrknox
reviewed
Oct 20, 2024
…o gcc_13_support
byrnHDF
reviewed
Oct 21, 2024
| @@ -28,7 +28,7 @@ permissions: | |||
|
|
|||
| jobs: | |||
| check: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-24.04 | |||
There was a problem hiding this comment.
Should we not specify latest and always use a specific version on all CI?
bmribler
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.