Remove some Solaris Studio work-arounds #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solaris Studio hasn't been updated in almost a decade and the last version (12.4, circa 2015) doesn't seem to fully support C11. This PR removes some work-arounds for things like __attribute__() support.
derobins
added
Priority - 2. Medium ⏹
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
|
H5LTparse.c and H5LTanalyze.c are generated files, but I decided to not regenerate them since the only thing that changed was the warning block we add from genparser. |
derobins
commented
Oct 19, 2024
| # Check for Solaris | ||
| if (${CMAKE_SYSTEM_NAME} MATCHES "SunOS") | ||
| set (${HDF_PREFIX}_HAVE_SOLARIS 1) | ||
| endif () |
There was a problem hiding this comment.
H5_HAVE_SOLARIS is unused in the library
mattjala
approved these changes
Oct 19, 2024
bmribler
approved these changes
Oct 19, 2024
qkoziol
approved these changes
Oct 19, 2024
qkoziol
pushed a commit
to qkoziol/hdf5
that referenced
this pull request
Oct 23, 2024
Solaris Studio hasn't been updated in almost a decade and the last version (12.4, circa 2015) doesn't seem to fully support C11. This PR removes some work-arounds for things like __attribute__() support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solaris Studio hasn't been updated in almost a decade and the last version (12.4, circa 2015) doesn't seem to fully support C11.
This PR removes some work-arounds for things like attribute() support.