Remove another couple of H5E_clear_stack calls #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up links test. Signed-off-by: Quincey Koziol <[email protected]>
qkoziol
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
Signed-off-by: Quincey Koziol <[email protected]>
qkoziol
added
Merge
Signed-off-by: Quincey Koziol <[email protected]>
mattjala
approved these changes
Oct 18, 2024
|
Note that this change corrects a failure in H5Oexists / H5Oexists_by_name, which should have returned 'false' and not failed. (This is why the Julia test is failing, since it is checking for the failure instead of false) |
jhendersonHDF
added
Merge - To 2.0
Ignores some of the older Autotools platform files, since the Autotools will be dropped in the next major release (and we don't have compilers on which to test, anyway). Also drops support for the old, non-compliant MSVC preprocessor.
The high-level GIF tools, h52gif and gif2h5, have unfixed CVE issues (with no proof-of-concept files). They are not critical tools, are not well maintained, and are an odd fit for building with the library. Because of this, they have been removed. We may move them to a separate repository in the future.
Signed-off-by: Quincey Koziol <[email protected]>
Signed-off-by: Quincey Koziol <[email protected]>
derobins
approved these changes
Oct 22, 2024
derobins
added a commit
to derobins/hdf5
that referenced
this pull request
Oct 23, 2024
PR HDFGroup#4968 fixes a bug that causes the Julia CI to fail due to buggy HDF5 behavior. The Julia CI will need to be updated to properly test the fixed feature.
Merged
derobins
added a commit
that referenced
this pull request
Oct 23, 2024
PR #4968 fixes a bug that causes the Julia CI to fail due to buggy HDF5 behavior. The Julia CI will need to be updated to properly test the fixed feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And clean up the links test, which had a ton of copy-and-pasted incorrect negative error checks. (Calling TEST_ERROR within H5E_BEGIN_TRY / H5E_END_TRY pairs will
gotoout of the pair, leaving errors suppressed)