Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync 1.14 branch with develop #3705

Merged
merged 25 commits into from
Oct 18, 2023
Merged

Sync 1.14 branch with develop #3705

merged 25 commits into from
Oct 18, 2023

Conversation

jhendersonHDF
Copy link
Collaborator

No description provided.

brtnfld and others added 24 commits October 17, 2023 21:19
@brtnfld @jhendersonHDF
Address nagfor exceptions stoppage. (HDFGroup#3658)
a3e2311 
* added cmake ieee flag for nagfor

* generalized determining the nag compiler

* fixing some misc. NAG warnings
@hyoklee @jhendersonHDF
Simplify. (HDFGroup#3659)
c4a9b32 
* Address @jhendersonHDF review
@jhendersonHDF
Add expedited testing support to t_filters_parallel (HDFGroup#3665)
90ea5ac
@hyoklee @jhendersonHDF
Remove clang warnings (HDFGroup#3656)
6fc9d82
@brtnfld @jhendersonHDF
Fixes test failure for gfortran -O2 and -O3, -fdefault-real-16 (HDFGr…
43d91bd 
…oup#3662)

* added cmake ieee flag for nagfor

* fixes gfortran -O2 and -O3, -fdefault-real-16

* fixed sync

* updated release notes
@hyoklee @jhendersonHDF
Fix link error on clang17/gfortran13/macOS-13 (HDFGroup#3666) (HDFGro…
625daf5 
…up#3671)
@byrnHDF @jhendersonHDF
Correct fortran CMake generator expressions (HDFGroup#3670)
442f15e
@hyoklee @jhendersonHDF
Add AOCC GitHub Action (HDFGroup#3504) (HDFGroup#3657)
73692ee
@derobins @jhendersonHDF
Fix uninitialized subfiling test variable (HDFGroup#3675)
459598c 
Picked up by gcc 10 on skybridge. Probably spurious, but no harm in
initializing it to a "bad" value.
@derobins @jhendersonHDF
Add support for AOCC & Flang w/ the Autotools (HDFGroup#3674)
71fb6ba 
* Adds a config/clang-fflags options file to support Flang
* Corrects missing "-Wl," from linker options in the libtool wrappers
  when using Flang, the MPI Fortran compiler wrappers, and building
  the shared library. This would often result in unrecognized options
  like -soname.
* Enable -nomp w/ Flang to avoid linking to the OpenMPI library.

CMake can build the parallel, shared library w/ Fortran using AOCC
and Flang, so no changes were needed for that build system.

Fixes GitHub issues HDFGroup#3439, HDFGroup#1588, HDFGroup#366, HDFGroup#280
@derobins @jhendersonHDF
Fix a strncpy call to use dest size not src (HDFGroup#3677)
49ed7eb 
A strncpy call in a path construction call used the size of the src
buffer instead of the dest buffer as the limit n.

This was switched to use the dest size and properly terminate the
string if truncation occurs.
@derobins @jhendersonHDF
Remove CANBE_UNUSED() from subfiling VFD (HDFGroup#3678)
267719b 
This macro was an attempt to quiet warnings about release mode unused
variables that only appear in asserts. It resolves to a void cast, which
doesn't quiet warnings when an assignment has already taken place.
@derobins @jhendersonHDF
Suppress MPI_Waitall warnings w/ MPICH (HDFGroup#3680)
263b8b0 
MPICH defines MPI_STATUSES_IGNORE (a pointer) to 1, which raises warnings
w/ gcc. This is a known issue that the MPICH devs are not going to fix.

See here:
    pmodels/mpich#5687

This fix suppresses those issues w/ gcc
@derobins @jhendersonHDF
Fix a possible NULL pointer dereference in tests (HDFGroup#3676)
1324276 
The dtypes test could dereference a NULL pointer if a strdup call
failed.
@derobins @jhendersonHDF
Fix printf warnings in t_mpi (HDFGroup#3679)
468e087 
* Fix printf warnings in t_mpi

The type of MPI_Offset varies with implementation. In MPICH, it's long,
which raises warnings when we attempt to use long long format
specifiers. Casting to long long fixes the warnings.
@derobins @jhendersonHDF
Fix invalid memory access in S3 comms (HDFGroup#3681)
3561e2b 
In the ros3 VFD, passing an empty string parameter to an internal
API call could result in accessing the -1th element of a string.
This would cause failures on big-endian systems like s390x.

This parameter is now checked before writing to the string.

Fixes GitHub HDFGroup#1168
@derobins @jhendersonHDF
Add Doxygen for H5Pset_fapl_sec2() (HDFGroup#3685)
c3b8078 
*
@brtnfld @jhendersonHDF
switch to using time function instead of date function (HDFGroup#3690)
72a5f2b
@jhendersonHDF
Initialize API context MPI types to MPI_BYTE (HDFGroup#3688)
3e22157
@jhendersonHDF
Add test info output to t_filters_parallel (HDFGroup#3696)
1872b1c
@derobins @jhendersonHDF
Suppress format string warnings in subfiling test (HDFGroup#3699)
85a530b
@derobins @jhendersonHDF
Fix unused variable in tselect.c (HDFGroup#3701)
5c9d76c
@derobins @jhendersonHDF
Fix unused variable warning in H5F_sfile_assert_num (HDFGroup#3700)
e686637
@derobins @jhendersonHDF
Restore floating-point suffixes in tests (HDFGroup#3698)
224936b 
A prior commit removed too many F suffixes. This restores the suffixes
for float variables.
@jhendersonHDF jhendersonHDF added Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - C Library Core C library issues (usually in the src directory) Component - High-Level Library Code in the hl directory Component - Documentation Doxygen, markdown, etc. Component - Fortran Fortran wrappers labels Oct 18, 2023
@jhendersonHDF jhendersonHDF added Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category Branch - 1.14 Component - Misc Anything else (CODEOWNERS, etc.) labels Oct 18, 2023
jhendersonHDF
jhendersonHDF commented Oct 18, 2023
View reviewed changes
java/src/jni/h5aImp.c
@@ -1186,7 +1186,7 @@ Java_hdf_hdf5lib_H5_H5AwriteVL(JNIEnv *env, jclass clss, jlong attr_id, jlong me
UNUSED(clss);

if (NULL == buf)
H5_NULL_ARGUMENT_ERROR(ENVONLY, "H5AwriteVL: write buffer is NULL");
H5_NULL_ARGUMENT_ERROR(ENVONLY, "H5Awrite: write buffer is NULL");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the wrong way to go since the function is called H5AwriteVL, but there are several other messages in develop that need updating, so this just makes the two branches consistent for now

@derobins derobins merged commit 4a02890 into HDFGroup:hdf5_1_14 Oct 18, 2023
40 checks passed
@jhendersonHDF jhendersonHDF deleted the 1_14_dev_sync branch October 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Component - Documentation Doxygen, markdown, etc. Component - Fortran Fortran wrappers Component - High-Level Library Code in the hl directory Component - Misc Anything else (CODEOWNERS, etc.) Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Task Actions that don't fit into any other type category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jhendersonHDF @derobins @brtnfld @hyoklee @byrnHDF