-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an upgrade guide to the documentation #8
Conversation
I have no idea why this PR shows other commits from 4 months ago... I forked the repo anew and created a dedicated branch for this commit. However, it seems that I did something wrong. If this causes any troubles, let me know and I provide a new PR. Set to "In progress" for the moment. |
In a commit I wrote: The upgrade guide tries to cover as many steps as possible, at least those I encountered during the update. Is there anything I didn't think of? Or do you think those are too many? Please let me know! Thanks! |
Did you also delete your local clone? If you remove the fork the new one should be up to date with the upstream. And since some time there is a new feature at GH to synchronize your existing fork with the upstream: But it looks this should not be an issue, no changes are shown from the previous commits. |
Thanks for your PR. I like to get rid of the current issues in ddev-typo3-src/bin/install-typo3 Lines 98 to 108 in 86eca96
After that the upgrade instruction should get shorter... I will add my changes to your PR here so we get rid of it in one step. |
Thinking out loud: Reading through the TYPO3 and the ddev docs I observe that the public folder is usually called just that: |
I've called it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I did some minor changes and also added my fix of the install script. I did a force push to the branch to get rid of the 3 unwanted commits so please use git pull --force
to get these changes.
* [BUGFIX] Fix installation with existing files * [DOCS] Add upgrade guide * [DOCS] Make upgrades easier * Move "deleted db" scenario to "trouble shooting" * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Simon Gilli <[email protected]>
* [BUGFIX] Fix installation with existing files * [DOCS] Add upgrade guide * [DOCS] Make upgrades easier * Move "deleted db" scenario to "trouble shooting" * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Simon Gilli <[email protected]>
* [BUGFIX] Fix installation with existing files * [DOCS] Add upgrade guide * [DOCS] Make upgrades easier * Move "deleted db" scenario to "trouble shooting" * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Simon Gilli <[email protected]>
* [BUGFIX] Fix installation with existing files * [DOCS] Add upgrade guide * [DOCS] Make upgrades easier * Move "deleted db" scenario to "trouble shooting" * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Simon Gilli <[email protected]>
* [BUGFIX] Fix installation with existing files * [DOCS] Add upgrade guide * [DOCS] Make upgrades easier * Move "deleted db" scenario to "trouble shooting" * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Simon Gilli <[email protected]>
* [BUGFIX] Fix installation with existing files * [DOCS] Add upgrade guide * [DOCS] Make upgrades easier * Move "deleted db" scenario to "trouble shooting" * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Simon Gilli <[email protected]>
Add upgrade guide as discussed here: #7