Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated gsdevkit_launcher use of mktemp to support both linux and OSX #305

Open
wants to merge 1 commit into
base: issue_260
Choose a base branch
from

Conversation

JupiterJones
Copy link
Contributor

on OSX the -p

option is not supported and the XXX replacement only works if it's at the end of the file name.

command was changed to: mktemp /tmp/gsdevkit.XXXXXXXXXX

on OSX the -p <DIR> option is not supported and the XXX replacement only works if it's at the end of the file name.

command was changed to: mktemp /tmp/gsdevkit.XXXXXXXXXX
@dalehenrich
Copy link
Member

@JupiterJones, I don't think the the travis build failure is related to https://travis-ci.org/github/GsDevKit/GsDevKit_home/jobs/762710796, although it may be true that the issue_260 branch never worked with 2,4,8 ... also I don't think it is necessary to spend too much time on issue_260 branch ... the issue_260_2021 branch is a fork off of a recent master branch (issue_260 is a couple of years old) ... and my plan is to basically cherry-pick things from issue_260 that are needed and then modify them to work superdoit ...

With that said, it IS interesting to know that -p option doesn't work in OSX, since I may use similar code in tODE and Rowan(?), so I will want to make a scan to clean them up ... before you hit them again :)

@dalehenrich
Copy link
Member

Oh and I made you a member of the Core team so you should have admin privileges and you should be able to merge pull requests yourself ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants