Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[next]: DaCe CFG analysis -> remove structurally inaccessible states #1598

Closed
wants to merge 1 commit into from
Closed

fix[next]: DaCe CFG analysis -> remove structurally inaccessible states #1598

wants to merge 1 commit into from

Conversation

kotsaloscv
Copy link
Contributor

This workaround fixes this DaCe issue.

@kotsaloscv kotsaloscv requested a review from edopao July 31, 2024 12:22
@kotsaloscv kotsaloscv self-assigned this Jul 31, 2024
@edopao
Copy link
Contributor

edopao commented Jul 31, 2024

Just for me to understand a bit better why we have structurally inaccessible states.. which icon4py stencil is causing this issue?

@kotsaloscv
Copy link
Contributor Author

Just for me to understand a bit better why we have structurally inaccessible states.. which icon4py stencil is causing this issue?

It is the calculate_enhanced_diffusion_coefficients_for_grid_point_cold_pools in the Diffusion Granule. I have also attached the SDFG for this specific stencil in the DaCe issue.

@edopao
Copy link
Contributor

edopao commented Jul 31, 2024

Just for me to understand a bit better why we have structurally inaccessible states.. which icon4py stencil is causing this issue?

It is the calculate_enhanced_diffusion_coefficients_for_grid_point_cold_pools in the Diffusion Granule. I have also attached the SDFG for this specific stencil in the DaCe issue.

To me it looks like the SDFG is wrong: the start block of the NestedSDFG is undefined. Can you please try this other PR? #1599

@kotsaloscv
Copy link
Contributor Author

kotsaloscv commented Aug 2, 2024 •
edited
Loading

Just for me to understand a bit better why we have structurally inaccessible states.. which icon4py stencil is causing this issue?

It is the calculate_enhanced_diffusion_coefficients_for_grid_point_cold_pools in the Diffusion Granule. I have also attached the SDFG for this specific stencil in the DaCe issue.

To me it looks like the SDFG is wrong: the start block of the NestedSDFG is undefined. Can you please try this other PR? #1599

Indeed this fix works. I close this one and we merge your PR.

cc: @edopao

@kotsaloscv kotsaloscv closed this Aug 2, 2024
@kotsaloscv
Copy link
Contributor Author

kotsaloscv commented Aug 2, 2024 •
edited
Loading

actual fix #1599

@kotsaloscv kotsaloscv deleted the kotsalos/dace_cfg_fix branch August 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edopao edopao Awaiting requested review from edopao

Assignees

@kotsaloscv kotsaloscv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFG analysis does not handle properly SDFGs with structurally inaccessible states
2 participants
@kotsaloscv @edopao