Test email options #283
Open
Test email options #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
652
to
656
| email.Body = GetBody(htmlDocument); | ||
| email.Subject = GetSubject(htmlDocument, emailType); | ||
|
|
||
| if (string.IsNullOrEmpty(smtpServer)) | ||
| return; |
There was a problem hiding this comment.
I see you put the calls to GetBody() and GetSubject() before checking for smtpServer. Should we also modify WriteEmailToFile() so it can be invoked even without an SMTP server?
…edEmailDataSource model
… could fail to be loaded into the database
|
Pushing what I have so far. I didn't get around to actually cleaning up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endpoint to test email via download of file or writing it to the fileshare