Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes in NoiseData transformer #112

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: Fixes in NoiseData transformer #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions internal/db/postgres/transformers/noise_date.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,14 @@ var NoiseDateTransformerDefinition = utils.NewTransformerDefinition(

toolkit.MustNewParameterDefinition(
"min_ratio",
"min random duration for noise",
"min random duration for noise. Dy default 5% of the max_ratio",
).SetCastDbType("interval"),

toolkit.MustNewParameterDefinition(
"max_ratio",
"max random duration for noise. Dy default 5% of the max_ratio",
).SetCastDbType("interval"),
"max random duration for noise",
).SetRequired(true).
SetCastDbType("interval"),

toolkit.MustNewParameterDefinition(
"min",
Expand Down Expand Up @@ -170,7 +171,7 @@ func NewNoiseDateTransformerBase(ctx context.Context, driver *toolkit.Driver, pa
}

warn := validateIntervalValue(maxRatio)
if warns != nil {
if warn != nil {
warn.AddMeta("ParameterName", "max_ratio")
warns = append(warns, warn)
}
Expand All @@ -187,7 +188,7 @@ func NewNoiseDateTransformerBase(ctx context.Context, driver *toolkit.Driver, pa
return nil, nil, fmt.Errorf("unable to scan \"max_ratio\" param: %w", err)
}
warn = validateIntervalValue(minRatio)
if warns != nil {
if warn != nil {
warn.AddMeta("ParameterName", "min_ratio")
warns = append(warns, warn)
}
Expand Down
3 changes: 2 additions & 1 deletion internal/db/postgres/transformers/random_date.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ func validateDateTruncationParameterValue(p *toolkit.ParameterDefinition, v tool
toolkit.NewValidationWarning().
SetSeverity(toolkit.ErrorValidationSeverity).
AddMeta("ParameterValue", string(v)).
SetMsg("wrong truncation part value: must be one of nano, second, minute, hour, day, month, year"),
AddMeta("AllowedValues", truncateParts).
SetMsg("wrong truncation part value"),
}, nil
}
return nil, nil
Expand Down