Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added datanode permissions #20608

Merged
merged 3 commits into from
Oct 2, 2024
Merged

added datanode permissions #20608

merged 3 commits into from
Oct 2, 2024

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Oct 1, 2024 •
edited
Loading

Motivation and Context

fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/8779

Screenshots (if appropriate):

Screenshot 2024-10-01 at 18 32 28

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Oct 1, 2024
ousmaneo
ousmaneo approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

moesterheld
moesterheld approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and lgtm. Thanks for the quick fix

moesterheld
moesterheld approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and lgtm. Thanks for the quick fix

@moesterheld moesterheld merged commit 1893901 into master Oct 2, 2024
7 checks passed
@moesterheld moesterheld deleted the fix-datanode-permissions branch October 2, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousmaneo ousmaneo ousmaneo approved these changes

@moesterheld moesterheld moesterheld approved these changes

@todvora todvora Awaiting requested review from todvora

@grotlue grotlue Awaiting requested review from grotlue

Assignees

@gally47 gally47

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gally47 @ousmaneo @moesterheld