Use Modal confirm when deleting stream and show DWH warning. #20224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check if dwh enabled or has data
ousmaneo
force-pushed
the
stream-delete-modal-dwh
branch
from
764ed64
to
46383bf
Compare
ousmaneo
force-pushed
the
stream-delete-modal-dwh
branch
from
e810a64
to
8ea8db8
Compare
ousmaneo
force-pushed
the
stream-delete-modal-dwh
branch
from
8ea8db8
to
6b6031c
Compare
gally47
requested changes
Aug 26, 2024
| onCancel: () => void, | ||
| }; | ||
|
|
||
| const useStreamDataWarehouseHasData = (streamId: string, enabled: boolean) => { |
There was a problem hiding this comment.
I think it's good to extract this hook into a file in the hooks repo, it might be used elsewhere, wdyt?
| ); | ||
| }; | ||
|
|
||
| const useIsStreamDataWarehouseEnabled = (streamId: string, enabled: boolean) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, deleting a stream was used to show the confirm base and
windows.confirmwith this change, we are usingConfirmModalComponent.We are also adding the possibility to display a warning when DWH is enabled or has data on the stream.
/nocl
/jpd Graylog2/graylog-plugin-enterprise#8291
Types of changes
Checklist: