Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds stream categories to dashboard widgets #20199

Merged
merged 41 commits into from
Sep 4, 2024
Merged

Adds stream categories to dashboard widgets #20199

merged 41 commits into from
Sep 4, 2024

Conversation

kingzacko1
Copy link
Contributor

@kingzacko1 kingzacko1 commented Aug 16, 2024 •
edited
Loading

Description

Adds stream categories to Widgets so they can be scoped to stream categories.
Offshoot PR of #20110.

/nocl will be added to CL on main PR

Motivation and Context

https://github.com/Graylog2/graylog-plugin-enterprise/issues/7926

How Has This Been Tested?

Tested locally by manually adding stream_categories field to a MessagesWidget on a saved dashboard. Will continue testing other widgets.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

kingzacko1 and others added 15 commits August 7, 2024 13:44
@kingzacko1
Add StreamCategoryFilter and stream_category to StreamDTO
0ec884c
@kingzacko1
Fix introduced test failures
c272dea
@kingzacko1
Remove streamService from eventlists and messagelists
2ac60fa
@kingzacko1
Merge branch 'master' into add-stream-category-filter
874e188
@kingzacko1
Merge remote-tracking branch 'origin/master' into add-stream-category…
b5784cb 
…-filter
@kingzacko1
Move StreamCategory resolution to SearchExecutor from SearchBackend
3c0d90d
@kingzacko1
revert unnecessary changes
ddec6c0
@kingzacko1
Add logic to populate queries with streamcategories with streamIds
5f19b85
@kingzacko1
Move streamcategory mapping from CommandFactory to MessagesResource
38390da
@kingzacko1
Fix MessagesResourceTest
2175a6f
@kingzacko1
Revert unused changes
a7d1e54
@kingzacko1
Merge remote-tracking branch 'origin/master' into add-stream-category…
a762413 
…-filter
@kingzacko1
Merge branch 'master' into add-stream-category-filter
cb42003
@kingzacko1
cl
55efe86
@kingzacko1
Adds stream categories to dashboard widgets
1f84f6e
kingzacko1 and others added 9 commits August 19, 2024 08:45
@kingzacko1
Merge remote-tracking branch 'origin/master' into add-stream-category…
e9c32af 
…-filter
@kingzacko1
Add enterprise issue to changelog
865a36d
@kingzacko1
Merge branch 'add-stream-category-filter' into add-stream-categories-…
10f384a 
…to-dashboard-widgets
@kingzacko1
Merge remote-tracking branch 'origin/master' into add-stream-category…
cf62e8e 
…-filter
@kingzacko1
Replace StreamCategoryFilters with StreamFilters in place instead of …
0578852 
…at top level
@kingzacko1
Merge branch 'add-stream-category-filter' into add-stream-categories-…
ead7631 
…to-dashboard-widgets
@kingzacko1
Merge remote-tracking branch 'origin/master' into add-stream-category…
e066ada 
…-filter
@kingzacko1
Move StreamCategory to StreamFilter logic and address other feedback
43a84e0
@kingzacko1
Merge branch 'add-stream-category-filter' into add-stream-categories-…
26446ca 
…to-dashboard-widgets
Base automatically changed from add-stream-category-filter to master August 26, 2024 16:51
@kingzacko1 kingzacko1 marked this pull request as ready for review August 29, 2024 16:59
danotorrey
danotorrey approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests successfully

ryan-carroll-graylog
ryan-carroll-graylog approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests successfully!

@kingzacko1 kingzacko1 merged commit 16ff8aa into master Sep 4, 2024
9 of 10 checks passed
@kingzacko1 kingzacko1 deleted the add-stream-categories-to-dashboard-widgets branch September 4, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danotorrey danotorrey danotorrey approved these changes

@ryan-carroll-graylog ryan-carroll-graylog ryan-carroll-graylog approved these changes

@dennisoelkers dennisoelkers Awaiting requested review from dennisoelkers

@kmerz kmerz Awaiting requested review from kmerz

@simonychuang simonychuang Awaiting requested review from simonychuang

@zeeklop zeeklop Awaiting requested review from zeeklop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingzacko1 @danotorrey @ryan-carroll-graylog @zeeklop