Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typings for mongoose model #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sojharo
Copy link

@sojharo sojharo commented Sep 27, 2022

Types should not extend Document as per discussion in #88

@lorensr
Copy link
Member

lorensr commented Oct 8, 2022

Hey @sojharo, sorry for the delay, and thanks for the contribution! Did you test the types manually for both MongoDB Collections and Mongoose Models? If you feel like an automated test (just running tsc on an example ts file), that would be helpful ☺️

@sojharo
Copy link
Author

sojharo commented Oct 14, 2022

Hey, I had the library installed in my current project and went into node_modules folder to do the changes and then test with my current project. I was able to reproduce the issue and then solve it with these changes in index.d.ts which are in this PR. When I run the project, I compile it using sucrase-node library so it compiles the typescript to javascript.

@andrmaz
Copy link

andrmaz commented Jan 3, 2023

@lorensr Any progress on this PR ?

@sojharo
Copy link
Author

sojharo commented Mar 1, 2023

Hey, yes. I had tested them with tsc and also tested it with my project by doing these changes directly inside installed version inside node_modules folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants