Upgrade Hadoop to 2.10.2/3.2.4. #988
Conversation
cnauroth
requested review from
arunkumarchacko,
davidrabinowitz and
singhravidutt
|
/gcbrun |
cnauroth
force-pushed
the
branch-2.1.x-upgrade-hadoop
branch
from
6a4a61a
to
dd52c91
Compare
| @@ -611,6 +612,24 @@ protected int getDefaultPort() { | |||
| return result; | |||
| } | |||
|
|
|||
| public boolean hasPathCapability(Path path, String capability) throws IOException { | |||
There was a problem hiding this comment.
The upgrade brings in a new contract test that asserts for these capabilities. This fix is already present in master and branch-2.2.x, so I brought over the same code. The indentation on the comment looks off to me, but that's the way Spotless wants it.
|
/gcbrun |
| @@ -611,6 +612,24 @@ protected int getDefaultPort() { | |||
| return result; | |||
| } | |||
|
|
|||
| public boolean hasPathCapability(Path path, String capability) throws IOException { | |||
| switch (validatePathCapabilityArgs(path, capability)) { | |||
| // TODO: remove string literals in favor of Constants in CommonPathCapabilities.java | |||
There was a problem hiding this comment.
I believe this patch[1] even handles this TODO. Can you please take care of that too? I will take care of it in 2.2.x
There was a problem hiding this comment.
No, we won't be able to include that change. It would work for Hadoop 3, but Hadoop 2 doesn't have the CommonPathCapabilities class that defines the constants. (Notice that the patch was committed only to master, where we dropped Hadoop 2 support.)
There was a problem hiding this comment.
Taking into account that 1.5 DPGCE will be EOS in few days, and we do not plan support 2.1 branch after this. I think that maybe we should not submit any new commits here?
No description provided.