Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widevine L3 DRM support #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Widevine L3 DRM support #16

wants to merge 1 commit into from

Conversation

mikegapinski
Copy link
Collaborator

I don't expect this to be merged as is, I'll just leave it here for people who want to use widevine L3 DRM in their roms.

@mikegapinski mikegapinski changed the title Added widevine drm support Widevine L3 DRM support Apr 16, 2023
@mikegapinski mikegapinski marked this pull request as draft April 16, 2023 15:20
$(call inherit-product, vendor/brcm/rpi4/rpi4-vendor.mk)

PRODUCT_PACKAGES += \
android.hardware.drm-service.clearkey \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ -.-.-.-.widevine \ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my bad, didn't see manifest changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to move those to gd_rpi4/drm or leave them in the vendor repo... if they stay in the vendor I should also move the Wi-Fi/BT firmware there to be consistent.

That's why I left this as a draft, we need to decide if we want L3 DRM support. If we do it is worth checking if it works on the pine phones or not. It should, L3 is software DRM.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsglobal do you want to include L3 DRM for RP4? If yes, I'll clean up this draft and get rid of the /vendor/brcm/rpi4 repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is the legal one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is the legal one.

I get it, L3 is available on Raspbian by apt (libwidevinecdm0). The question is whether we can include the android equivalent or not... I don't know how the license works

Copy link
Collaborator Author

@mikegapinski mikegapinski Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.tomshardware.com/uk/news/raspberry-pi-widevine

I could try reaching out to the foundation and see what they say, I am no lawyer. Those libs show up everywhere: https://gitlab.com/rockchip_android_s/rk/platform/vendor/Widevine/-/commit/785cdb58f100144c365f80ad47995b1989557467

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those libs I use come from coral-tp1a.220624.014 btw, I can always add a setup-makefiles script and include them conditionally. But does it change anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants