Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge floodgate-fabric #353

Closed
wants to merge 11 commits into from
Closed

Merge floodgate-fabric #353

wants to merge 11 commits into from

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Sep 21, 2022

Things to note:

  • Loom adds repositories so dependencies cannot be defined in the gradle settings script.
  • Within the gradle plugin classpath, there is a version conflict between loom and some other plugin for jackson's databind. Adding databind as a dependency, in build-logic fixes this (with the version used by loom).
  • Gradle has been updated from 7.3.3 to 7.4.2 due to an error/warning regarding Java 17

Current issues:

  • It seems that either loom or shadow freak out when they encounter LWJGL's Java 19 multi release code. Currently shadow is throwing the error.
  • There is an issue with this conversion from the original. Something about the type of the list elements.

@onebeastchris
Copy link
Member

Superseded by #466

@Konicai Konicai deleted the fabric branch November 18, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants