fix(supabase): remove limit and select from delete #449 (#450)

GetDutchie · Sep 30, 2024 · 6112b8a · 6112b8a
1 parent 3e182ec
commit 6112b8a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/packages/brick_supabase/CHANGELOG.md b/packages/brick_supabase/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## Unreleased
 
+## 1.0.3
+
+- Remove `select` from `#delete`
+
 ## 1.0.2
 
 - Only specify key lookup in query transformer if `RuntimeSupabaseColumnDefinition#foreignKey` is specified

diff --git a/packages/brick_supabase/lib/src/supabase_provider.dart b/packages/brick_supabase/lib/src/supabase_provider.dart
@@ -29,9 +29,6 @@ class SupabaseProvider implements Provider<SupabaseModel> {
     final tableBuilder = client.from(adapter.supabaseTableName);
     final output = await adapter.toSupabase(instance, provider: this, repository: repository);
 
-    final queryTransformer =
-        QuerySupabaseTransformer<TModel>(modelDictionary: modelDictionary, query: query);
-
     final builder = adapter.uniqueFields.fold(tableBuilder.delete(), (acc, uniqueFieldName) {
       final columnName = adapter.fieldsToSupabaseColumns[uniqueFieldName]!.columnName;
       if (output.containsKey(columnName)) {
@@ -40,7 +37,7 @@ class SupabaseProvider implements Provider<SupabaseModel> {
       return acc;
     });
 
-    final resp = await builder.select(queryTransformer.selectFields).limit(1).maybeSingle();
+    final resp = await builder;
     return resp != null;
   }
 

diff --git a/packages/brick_supabase/lib/testing.dart b/packages/brick_supabase/lib/testing.dart
@@ -38,6 +38,12 @@ class SupabaseRequest<TModel extends SupabaseModel> {
         : fields;
     final generatedTableName =
         modelDictionary != null ? modelDictionary.adapterFor[TModel]?.supabaseTableName : tableName;
+
+    if (requestMethod == 'DELETE') {
+      final url = '/rest/v1/$generatedTableName${filter != null ? '?$filter&' : '?'}';
+      return Uri.parse(url);
+    }
+
     final url =
         '/rest/v1/$generatedTableName${filter != null ? '?$filter&' : '?'}select=${Uri.encodeComponent(generatedFields ?? '')}${limit != null ? '&limit=$limit' : ''}';
     return Uri.parse(url);

diff --git a/packages/brick_supabase/pubspec.yaml b/packages/brick_supabase/pubspec.yaml
@@ -4,7 +4,7 @@ homepage: https://github.com/GetDutchie/brick/tree/main/packages/brick_supabase
 issue_tracker: https://github.com/GetDutchie/brick/issues
 repository: https://github.com/GetDutchie/brick
 
-version: 1.0.2+1
+version: 1.0.3
 
 environment:
   sdk: ">=3.0.0 <4.0.0"

diff --git a/packages/brick_supabase/test/supabase_provider_test.dart b/packages/brick_supabase/test/supabase_provider_test.dart
@@ -18,7 +18,6 @@ void main() {
       final req = SupabaseRequest<DemoModel>(
         requestMethod: 'DELETE',
         filter: 'id=eq.1',
-        limit: 1,
       );
       final instance = DemoModel(age: 1, name: 'Demo 1', id: '1');
       final resp = SupabaseResponse(await mock.serialize(instance));