DKAN-4291 add mysql empty row removal option #4292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swirtSJW
force-pushed
the
DKAN-4291-add-mysql-empty-rows-option
branch
from
58145d4
to
5e7ec8f
Compare
swirtSJW
force-pushed
the
DKAN-4291-add-mysql-empty-rows-option
branch
from
5e7ec8f
to
01f1300
Compare
swirtSJW
commented
Sep 18, 2024
| @@ -128,7 +129,7 @@ protected function getColsFromFile(string $file_path, string $delimiter): array | |||
| $f = fopen($file_path, 'r'); | |||
|
|
|||
| // Ensure the file could be successfully opened. | |||
| if ($f === FALSE) { | |||
| if (!isset($f) || $f === FALSE) { | |||
There was a problem hiding this comment.
I think this is 2.18 cruft that snuck back in due to me working in 2.18. I will fix this and the others of similar sneakiness.
swirtSJW
commented
Sep 18, 2024
| // Ensure the columns of the resource file were successfully read. $columns | ||
| // could be array, FALSE, or NULL. | ||
| if (!$columns) { | ||
| // Ensure the columns of the resource file were successfully read. |
|
Thanks for working on this @swirtSJW please include tests for the new code. |
@swirtSJW check out the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4291
Describe your changes
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation