Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make line text optional #3631

Merged
merged 7 commits into from
Jul 17, 2023
Merged

Make line text optional #3631

merged 7 commits into from
Jul 17, 2023

Conversation

Huquette
Copy link
Contributor

@Huquette Huquette commented Jul 11, 2023 •
edited by camillemonchicourt
Loading

@Huquette Huquette requested a review from a team July 11, 2023 07:42
@cypress
Copy link

cypress bot commented Jul 11, 2023 •
edited
Loading

Passing run #6613 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge f4c383b into 53ff355...
Project: Geotrek-admin Commit: db1e22cbff ℹ️
Status: Passed Duration: 05:47 💡
Started: Jul 13, 2023 1:50 PM Ended: Jul 13, 2023 1:56 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (53ff355) 98.29% compared to head (f4c383b) 98.29%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3631   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         292      292           
  Lines       21654    21654           
=======================================
  Hits        21284    21284           
  Misses        370      370
Impacted Files Coverage Δ
geotrek/signage/models.py 98.41% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Huquette Huquette marked this pull request as ready for review July 11, 2023 10:40
@Huquette Huquette requested a review from Chatewgne July 11, 2023 10:41
@Huquette Huquette force-pushed the make_line_text_not_required branch from cf4bacd to b1638ce Compare July 12, 2023 12:27
@Huquette Huquette force-pushed the make_line_text_not_required branch from e881dad to f4c383b Compare July 13, 2023 13:33
@Huquette Huquette merged commit 5cdb354 into master Jul 17, 2023
14 checks passed
@Huquette Huquette deleted the make_line_text_not_required branch July 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillemonchicourt camillemonchicourt camillemonchicourt left review comments

@submarcos submarcos submarcos left review comments

@marcantoinedupre marcantoinedupre marcantoinedupre approved these changes

@Chatewgne Chatewgne Chatewgne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Huquette @camillemonchicourt @submarcos @marcantoinedupre @Chatewgne