Run Azure blob store integration tests with Azure and Azurite #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groldan
commented
Aug 11, 2024
geowebcache/core/src/test/java/org/geowebcache/storage/AbstractBlobStoreTest.java
Outdated
Show resolved
Hide resolved
|
please note the Azure online tests are being run against my free-tier account while I wait for camptocamp to provision an account we can use for testing. |
|
It seems all Azure tests are run twice, push vs pull_request?
|
aaime
reviewed
Aug 19, 2024
.../src/test/java/org/geowebcache/azure/tests/container/AzuriteAzureBlobStoreConformanceIT.java
Show resolved
Hide resolved
geowebcache/core/src/test/java/org/geowebcache/storage/AbstractBlobStoreTest.java
Outdated
Show resolved
Hide resolved
geowebcache/core/src/test/java/org/geowebcache/storage/AbstractBlobStoreTest.java
Outdated
Show resolved
Hide resolved
groldan
force-pushed
the
azureblob_run_integration_tests_on_github_actions
branch
from
691a5b8
to
31d0223
Compare
Azurite is run as a testcontainer, and the github CI build runs all integration tests for Java 11, 17, and 21. In order to save on Azure resources, online integration tests are run only if the Azurite based tests succeeded, using github secrets to set up the account, key, and container; and for Java 11 only.
groldan
force-pushed
the
azureblob_run_integration_tests_on_github_actions
branch
from
31d0223
to
57fecb1
Compare
|
Made it so the ITs only run with |
aaime
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azurite is run as a testcontainer, and the github CI build runs all integration tests for Java 11, 17, and 21.
In order to save on Azure resources, online integration tests are run only if the Azurite based tests succeeded, using github secrets to set up the account, key, and container; and for Java 11 only.
Both Azurite and Azure tests are run by the failsafe-maven-plugin, during the integration-test phase, so you need to run them as mvn verify, not as mvn test.
Fixes #1207