Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coveralls #359

Merged
merged 9 commits into from
Jul 18, 2024
Merged

Fix coveralls #359

merged 9 commits into from
Jul 18, 2024

Conversation

LSchueler
Copy link
Member

@LSchueler LSchueler commented Jul 18, 2024 •
edited
Loading

We are having problems with coveralls.io at the moment. By only running coveralls once during the source_check job, things should be running fine again.

@LSchueler LSchueler added this to the 1.6 milestone Jul 18, 2024
@LSchueler LSchueler self-assigned this Jul 18, 2024
MuellerSeb
MuellerSeb requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to run pytest as well.

Also, why is the index/readme hack in here?

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
src/gstools/field/summator.pyx Show resolved Hide resolved
@LSchueler LSchueler added the bug Something isn't working label Jul 18, 2024
@LSchueler
Copy link
Member Author

I think we need to run pytest as well.

Absolutely, added.

Also, why is the index/readme hack in here?

I have no idea. I've removed it.

@LSchueler
Copy link
Member Author

I think this is ready to be merged.

@LSchueler LSchueler marked this pull request as ready for review July 18, 2024 09:31
@MuellerSeb
Copy link
Member

Please commit my suggestion, then its ready from my side.

@LSchueler LSchueler merged commit f73ec6b into main Jul 18, 2024
27 of 28 checks passed
@LSchueler LSchueler deleted the coveralls branch July 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuellerSeb MuellerSeb MuellerSeb requested changes

Assignees

@LSchueler LSchueler

Labels
bug Something isn't working CI/CD
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@LSchueler @MuellerSeb