Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the color depth returned when reading the gray.cpt master CPT. #8522

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

joa-quim
Copy link
Member

The master CPT gray.cpt has only one slice that fits both the is_gray and is_bw tests and hence returns with both as true, which is obviously wrong and cause that when passed to grdimage together with a grid from Julia the image_8 container was not initialized and a crash followed (see GenericMappingTools/GMT.jl#1472).

Copy link
Contributor

@remkos remkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from changing "aout" to "out" in the comment above the code line, I think this is the right, and generic, approach.

@joa-quim
Copy link
Member Author

Corrected the typo.

@joa-quim joa-quim merged commit f9064b2 into master Jun 17, 2024
14 of 18 checks passed
@joa-quim joa-quim deleted the fix-palette-depth branch June 17, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants